Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create WebContents for webview on request (2-0-x) #13714

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

zcbenz commented Jul 18, 2018

Backports #13713 to 2-0-x.

@zcbenz zcbenz requested a review from as a code owner Jul 18, 2018

@zcbenz zcbenz force-pushed the fix-webview-attach-event-2-0x branch 3 times, most recently from f74d2ce to 7fdea9f Jul 18, 2018

@zcbenz zcbenz force-pushed the fix-webview-attach-event-2-0x branch from 7fdea9f to 033e328 Jul 18, 2018

@codebytere codebytere merged commit 9667b83 into 2-0-x Jul 20, 2018

14 checks passed

Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@codebytere codebytere deleted the fix-webview-attach-event-2-0x branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.