Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure DirectX capturer is supported. (backport: 3-0-x) #13738

Merged
merged 2 commits into from Jul 20, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Jul 19, 2018

Backport of #13543

See that PR for details.

resolve #13426

@trop trop bot requested a review from as a code owner Jul 19, 2018

@trop trop bot added the backport label Jul 19, 2018

@jkleinsc
Copy link
Contributor

jkleinsc left a comment

LGTM

@MarshallOfSound

This comment has been minimized.

Copy link
Member

MarshallOfSound commented Jul 20, 2018

@jkleinsc It looks like a whole bunch of CI didn't run here 🤔

@MarshallOfSound MarshallOfSound changed the title Ensure DirectX capturer is supported. (backport: 3-0-x) fix: ensure DirectX capturer is supported. (backport: 3-0-x) Jul 20, 2018

@MarshallOfSound MarshallOfSound merged commit 2955b01 into electron:3-0-x Jul 20, 2018

4 checks passed

Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.