chore: Chromium 67 #13756
Merged
chore: Chromium 67 #13756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
77f9b07
to
30f8da9
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
155a8bd
to
32d3a1f
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
3 times, most recently
from
0a9eda4
to
10273f6
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
519a333
to
07ba5a5
Compare
KoenLav
approved these changes
Aug 25, 2018
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
37ea92e
to
b9ce625
Compare
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
2 times, most recently
from
22b5cd8
to
076972c
Compare
|
Will this PR be included in the final release of 3.0? |
|
@KoenLav this PR is intended for 4.0 |
|
@jkleinsc any rough idea of a timeline for 4.0? Or will this PR also be backported to 3.0? We're hoping for quite some performance improvements from this PR (when compared to 2.0) :) |
|
@KoenLav at this point there is no specific timeline for 4.0. Due to our adoption of semantic versioning, the upgrade to Chromium 67 will not be backported to 3.0. |
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
beae267
to
a355453
Compare
nornagon
requested changes
Sep 10, 2018
Ideally widget delegates must outlive their widget, but since we manage the lifetime of native widget, allow the delegate to be destroyed when widget is destroyed. https://chromium-review.googlesource.com/c/chromium/src/+/977244
osr_render_widget_host_view.cc:1150:12: error: [chromium-style] auto variable type must not deduce to a raw pointer type. (cherry picked from commit cc8e4ef)
(cherry picked from commit da2b2e7)
* build: [m67] enable widevine support * fix: remove plugin cache reset hack It was added in (#8907) to make widevine cdm shows up in navigator.plugins, since widevine support is no longer enabled by a plugin it can be removed safely.
alexeykuzmin
force-pushed
the
chromium-upgrade/67
branch
from
efbe869
to
f76a8c7
Compare
|
Release Notes Persisted
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Chromium 67.0.3396.99
Node.js 10.6.0
Fixes #13683.
Project Board https://github.com/electron/electron/projects/11
PR to libcc electron/libchromiumcontent#607
notes: Use Chromium 67.