Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use --enable-features and --disable-features (2.0.x) #13782

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
4 participants
@poiru
Copy link
Member

poiru commented Jul 24, 2018

Unlike Chrome, we were not using the --enable-features and
--disable-features command-line arguments to initialize
base::FeatureList.

This backports #13784 to 2-0-x.

@poiru poiru requested a review from zcbenz Jul 24, 2018

@poiru poiru requested a review from as a code owner Jul 24, 2018

@poiru poiru force-pushed the fix-enable-disable-features-2-0-x branch from 75978dc to 67c998d Jul 24, 2018

const auto disable_features =
command_line->GetSwitchValueASCII(switches::kDisableFeatures);

std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);

This comment has been minimized.

@miniak

miniak Jul 24, 2018

Contributor

use auto feature_list = std::make_unique<base::FeatureList>(); instead

This comment has been minimized.

@poiru

poiru Jul 24, 2018

Author Member

We can't use that in this branch:

../../brightray/browser/browser_main_parts.cc:263:28: error: no member named 'make_unique' in namespace 'std'
  auto feature_list = std::make_unique<base::FeatureList>();

@poiru poiru force-pushed the fix-enable-disable-features-2-0-x branch 3 times, most recently from b1ae0d5 to 767536a Jul 24, 2018

fix: Use --enable-features and --disable-features (2.0.x)
Unlike Chrome, we were not using the --enable-features and
--disable-features command-line arguments to initialize
`base::FeatureList`.

@poiru poiru force-pushed the fix-enable-disable-features-2-0-x branch from 767536a to 6689dce Jul 24, 2018

@ckerr

ckerr approved these changes Jul 25, 2018

Copy link
Member

ckerr left a comment

👍 for the helpful description in BrowserMainParts::PreMainMessageLoopRun()

@zeke zeke merged commit a76adba into 2-0-x Jul 25, 2018

12 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
Semantic Pull Request good to go
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@poiru poiru deleted the fix-enable-disable-features-2-0-x branch Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.