Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use --enable-features and --disable-features (backport: 3-0-x) #13805

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Jul 25, 2018

Backport of #13784

See that PR for details.

fix: Use --enable-features and --disable-features
Unlike Chrome, we were not using the --enable-features and
--disable-features command-line arguments to initialize
`base::FeatureList`.

@trop trop bot requested a review from as a code owner Jul 25, 2018

@trop trop bot added the backport label Jul 25, 2018

@ckerr

ckerr approved these changes Jul 26, 2018

@ckerr ckerr merged commit b08df88 into electron:3-0-x Jul 26, 2018

9 of 12 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
appveyor: electron-x64-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request good to go
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.