New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 10962, crash when open devtool #13808

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
4 participants
@wenjunche

wenjunche commented Jul 25, 2018

Fixes #10962

In InspectableWebContentsImpl::WebContentsDestroyed, pending_requests_ is not cleared, so "delete pair.first" may be called multiple times for for same instance of URLFetcher.

Notes: Fix sporadic crash the occurred while opening devtools

@wenjunche wenjunche requested a review from electron/reviewers as a code owner Jul 25, 2018

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Jul 25, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome bot commented Jul 25, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@wenjunche wenjunche changed the title from fix for issue 10962: crash when open devtool to fix: issue 10962, crash when open devtool Jul 26, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Jul 26, 2018

Member

hi @wenjunche, it's not very clear what this fix is doing or why you chose to do it in this way.

The PR description has also been left blank and the checklist deleted, and without those we cannot review your PR as we can't be confident that it acts as intended and that you've ensured tests pass and your code lints correctly.

We can look at this PR once those things have been remedied.

Member

codebytere commented Jul 26, 2018

hi @wenjunche, it's not very clear what this fix is doing or why you chose to do it in this way.

The PR description has also been left blank and the checklist deleted, and without those we cannot review your PR as we can't be confident that it acts as intended and that you've ensured tests pass and your code lints correctly.

We can look at this PR once those things have been remedied.

@sofianguy

This comment has been minimized.

Show comment
Hide comment
@sofianguy

sofianguy Jul 26, 2018

Member

@wenjunche Thanks so much for this PR! Please follow @codebytere's instructions in the above comment so that we can get this moving along.

@codebytere FYI this is a PR from an App Feedback Program member. It's a fix for one of their issues 💫

Member

sofianguy commented Jul 26, 2018

@wenjunche Thanks so much for this PR! Please follow @codebytere's instructions in the above comment so that we can get this moving along.

@codebytere FYI this is a PR from an App Feedback Program member. It's a fix for one of their issues 💫

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Aug 2, 2018

Member

@wenjunche thanks for fixing the lint issue, if you can now update your PR body to describe the fix and how it works that would be great!

Member

codebytere commented Aug 2, 2018

@wenjunche thanks for fixing the lint issue, if you can now update your PR body to describe the fix and how it works that would be great!

@MarshallOfSound MarshallOfSound merged commit 8edd18b into electron:2-0-x Aug 24, 2018

12 of 13 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 24, 2018

Release Notes Persisted

Fix sporadic crash the occurred while opening devtools

release-clerk bot commented Aug 24, 2018

Release Notes Persisted

Fix sporadic crash the occurred while opening devtools

@welcome

This comment has been minimized.

Show comment
Hide comment
@welcome

welcome bot Aug 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

welcome bot commented Aug 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 24, 2018

An error occurred while attempting to backport this PR to "2-0-x",
you will need to perform this backport manually

trop bot commented Aug 24, 2018

An error occurred while attempting to backport this PR to "2-0-x",
you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 24, 2018

We have automatically backported this PR to "3-0-x", please check out #14303

trop bot commented Aug 24, 2018

We have automatically backported this PR to "3-0-x", please check out #14303

@trop trop bot added merged/3-0-x and removed target/3-0-x labels Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment