Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass scrollBounce by command line flag #13813

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
2 participants
@zcbenz
Copy link
Member

zcbenz commented Jul 26, 2018

Backports #13812 to 3-0-x.

fix: pass scrollBounce by command line flag
Implement the scrollBounce option by reading the command line flag in
`RenderThreadImpl::IsElasticOverscrollEnabled`, there is no more need
to set NSScrollViewRubberbanding.

@zcbenz zcbenz requested a review from as a code owner Jul 26, 2018

@zcbenz zcbenz merged commit a880e02 into 3-0-x Jul 26, 2018

12 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@zcbenz zcbenz deleted the scroll-bounce-cmd-flag-3-0-x branch Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.