Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SIGINT and SIGTERM from the Electron CLI helper (backport: 3-0-x) #13889

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Jul 31, 2018

Backport of #13867

See that PR for details.

@trop trop bot requested a review from electron/electrocats as a code owner Jul 31, 2018

@trop trop bot added the backport label Jul 31, 2018

@MarshallOfSound MarshallOfSound merged commit 13d3a05 into electron:3-0-x Aug 1, 2018

10 of 12 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.