New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to electron #1389

Merged
merged 31 commits into from Apr 17, 2015

Conversation

Projects
None yet
@kevinsawicki
Contributor

kevinsawicki commented Apr 8, 2015

When Atom Shell started over two years ago, its one and only consumer was the Atom editor.

And so the original Atom Shell name was just a stopgap to refer to the Chromium/Node integration pieces and the native bits for window management and OS integrations such as the clipboard, the dock, etc.

But over the last two years Atom Shell has grown and matured to become a framework that isn't just for building text editors. People are now using it to build email clients, design tools, chat clients, and video players.

It deserves a better name that decouples it from the Atom editor association and allows it to stand on its own and continue to become the easiest way to build native apps using web tech.

So the new name will be ⚡️ electron ⚡️ and this pull request will update all the places in the code and the docs to this new name.

/cc @atom/core @atom/non-github-maintainers

kevinsawicki added some commits Apr 8, 2015

@thomasjo

This comment has been minimized.

Contributor

thomasjo commented Apr 8, 2015

Awesome!
On Apr 8, 2015 7:06 PM, "Kevin Sawicki" notifications@github.com wrote:

When Atom Shell started over two years ago, its one and only consumer was
the Atom https://github.com/atom/atom editor.

And so the original Atom Shell name was just a stopgap to refer to the
Chromium/Node integration pieces and the native bits for window management
and OS integrations such as the clipboard, the dock, etc.

But over the last two years Atom Shell has grown and matured to become a
framework that isn't just for building text editors. People are now using
it to build email clients, design tools, chat clients, and video players.

It deserves a better name that decouples it from the Atom editor
association and allows it to stand on its own and continue to become the
easiest way to build native apps using web tech.

So the new name will be [image: ⚡️] electron [image: ⚡️] and this
pull request will update all the places in the code and the docs to this
new name.

https://camo.githubusercontent.com/326b68277c9d074b4de4d324c8a2274da219bc4b/68747470733a2f2f33332e6d656469612e74756d626c722e636f6d2f36383838396233303732373833643039333730303639363230653165356264632f74756d626c725f6d757477766a4c5a387431736a77777a736f315f3530302e676966

/cc @atom/core https://github.com/orgs/atom/teams/core
@atom/non-github-maintainers

https://github.com/orgs/atom/teams/non-github-maintainers

You can view, comment on, or merge this pull request online at:

#1389
Commit Summary

  • Begin Atom Shell -> Electron rename

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1389.

@marekhrabe

This comment has been minimized.

marekhrabe commented Apr 8, 2015

nice one, guys! we love it at @avocode :)

@@ -72,7 +72,7 @@
};
</script>
<h2 style="-webkit-app-region: drag">Welcome to Atom Shell</h2>
<h2 style="-webkit-app-region: drag">Welcome to Electron</h2>
<p>
To run your app with atom-shell, execute the following command under your

This comment has been minimized.

@50Wliu

50Wliu Apr 8, 2015

Contributor

Forgot to change it here

@@ -1,6 +1,6 @@
{
"name": "atom-shell-default-app",

This comment has been minimized.

@50Wliu

50Wliu Apr 8, 2015

Contributor

And here?

@@ -1,6 +1,6 @@
{
"name": "atom-shell-specs",

This comment has been minimized.

@50Wliu

50Wliu Apr 8, 2015

Contributor

And here

@YurySolovyov

This comment has been minimized.

Contributor

YurySolovyov commented Apr 8, 2015

.asar makes less sense with Electron, but it is not a huge deal.

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Apr 8, 2015

Yesssssss

@Tribex

This comment has been minimized.

Contributor

Tribex commented Apr 8, 2015

Oooh! Sounds nice!
"Quark" sounds better IMO though.

@mnquintana

This comment has been minimized.

Member

mnquintana commented Apr 9, 2015

@YuriSolovyov Although then we'd end up with .ear 😝

@YurySolovyov

This comment has been minimized.

Contributor

YurySolovyov commented Apr 9, 2015

@mnquintana it does not have to be ARchive, it can be a PACKage, or something.

@mnquintana

This comment has been minimized.

Member

mnquintana commented Apr 9, 2015

Now that I think about it, .elar wouldn't be bad.

@YurySolovyov

This comment has been minimized.

Contributor

YurySolovyov commented Apr 9, 2015

@kevinsawicki are you going to design a logo too?

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented Apr 9, 2015

Now that I think about it, .elar wouldn't be bad.

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 9, 2015

are you going to design a logo too?

Eventually yes, a new site is being worked on as well.

@thedaniel

This comment has been minimized.

Contributor

thedaniel commented Apr 9, 2015

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

☝️

It doesn't matter what the archive format is called, .asar is fine forever.

@thomasjo

This comment has been minimized.

Contributor

thomasjo commented Apr 9, 2015

It doesn't matter what the archive format is called, .asar is fine forever.

This.


If people are super bothered, we can imagine .asar being an abbreviation of Awesome Software ARchive or whatever.

@mnquintana

This comment has been minimized.

Member

mnquintana commented Apr 9, 2015

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

Haha no worries, I was just throwing around names not-so-seriously

@lee-dohm

This comment has been minimized.

@simurai simurai referenced this pull request Apr 16, 2015

Merged

Electron icon #1430

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 16, 2015

@zcbenz anything left to do here before shipping this?

Want to add a task list to the pull request body if there are still remaining items?

@jweinstein

This comment has been minimized.

jweinstein commented Apr 16, 2015

I am impressed by this diff.

.Append("MacOS")
.Append(PRODUCT_NAME " Helper");
base::FilePath frameworks_path = GetFrameworksPath();
base::FilePath helper_path = GetHeleprAppPath(frameworks_path,

This comment has been minimized.

@paulcbetts

paulcbetts Apr 16, 2015

Contributor

Typo?

zcbenz added a commit that referenced this pull request Apr 17, 2015

@zcbenz zcbenz merged commit cd0aa4a into master Apr 17, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zcbenz zcbenz deleted the rename-to-electron branch Apr 17, 2015

@jprichardson

This comment has been minimized.

Member

jprichardson commented Apr 20, 2015

Been using atom-shell for a few months. Electron is an excellent name and is better for marketing. I realize that many devs don't care about this, but it affects us all whether we know it or not. The bigger the community for Electron, the better it is all for all of us. Bravo!

@kevinsawicki

This comment has been minimized.

Contributor

kevinsawicki commented Apr 20, 2015

💚 💜 💙

martinchooooooo added a commit to martinchooooooo/LightTable that referenced this pull request Apr 23, 2015

Update build scripts for atom-shell name change to electron
Github has changed the name of atom-shell to electron as per
electron/electron#1389
@jjgod

This comment has been minimized.

jjgod commented on atom/browser/browser_win.cc in 2d8d328 Apr 23, 2015

It's better to use base::ASCIIToUTF16 instead of constructing base::string16 from L"".

This comment has been minimized.

Contributor

zcbenz replied Apr 25, 2015

Thanks for the tip!

@steelbrain

This comment has been minimized.

Contributor

steelbrain commented on 2d8d328 Apr 23, 2015

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment