New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process.execPath returning parent process path instead of the helper in sandboxed renderer (backport: 3-0-x) #13959

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@miniak
Contributor

miniak commented Aug 6, 2018

Backport #13839

Checklist

@miniak miniak requested review from electron/docs as code owners Aug 6, 2018

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak Aug 8, 2018

Contributor

@ckerr can you please merge?

Contributor

miniak commented Aug 8, 2018

@ckerr can you please merge?

@ckerr

ckerr approved these changes Aug 9, 2018

LGTM. Thanks for doing it manually.

@ckerr ckerr merged commit 98033e4 into 3-0-x Aug 9, 2018

12 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@ckerr ckerr deleted the miniak/fix-process-execpath-3.0 branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment