New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent menu update while it's open (backport: 2-0-x) #13966

Merged
merged 3 commits into from Aug 7, 2018

Conversation

Projects
None yet
4 participants
@sethlu
Member

sethlu commented Aug 7, 2018

Backport of #12809

See above PR for details.

sethlu added some commits May 3, 2018

Update application menu on default runloop
Menu change should be prevented while the menu is open

@sethlu sethlu requested a review from electron/reviewers as a code owner Aug 7, 2018

@jkleinsc jkleinsc merged commit bdc255f into 2-0-x Aug 7, 2018

11 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@jkleinsc jkleinsc deleted the 2-0-x-backport-12809 branch Aug 7, 2018

@daviwil daviwil referenced this pull request Aug 9, 2018

Merged

:arrow_up: electron@2.0.7 #17815

1 of 1 task complete

@shiftkey shiftkey referenced this pull request Aug 26, 2018

Closed

bump electron to latest stable #5462

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment