Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getUploadProgress API to the net API (backport: 2-1-x) #13985

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Aug 8, 2018

Backport of #13783

See that PR for details.

@trop trop bot requested review from as code owners Aug 8, 2018

@trop trop bot added the backport label Aug 8, 2018

@ckerr

ckerr approved these changes Aug 8, 2018

@ckerr

This comment has been minimized.

Copy link
Member

ckerr commented Aug 8, 2018

The CI failure is on an unrelated flake.

@ckerr ckerr merged commit 63402f3 into electron:2-1-x Aug 8, 2018

10 of 12 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.