New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ipcRemote.sendSync() in lib/isolated_renderer/init.js (backport: 3-0-x) #13997

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Aug 9, 2018

Backport of #13941

See that PR for details.

@trop trop bot requested a review from electron/reviewers as a code owner Aug 9, 2018

@trop trop bot referenced this pull request Aug 9, 2018

Merged

fix: ipcRemote.sendSync() in lib/isolated_renderer/init.js #13941

4 of 4 tasks complete

@trop trop bot added the backport label Aug 9, 2018

@miniak

This comment has been minimized.

Show comment
Hide comment
@miniak

miniak Aug 9, 2018

Contributor

@ckerr can you please merge?

Contributor

miniak commented Aug 9, 2018

@ckerr can you please merge?

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Aug 9, 2018

Member

appveyor: electron-ia32-pr failure is the app.enableMixedSandbox() flake

appveyor: electron-x64-pr failure is also unrelated to this PR:

Push-AppveyorArtifactInternal : File not found: C:\projects\electron-74j4h\out
At C:\Program Files\AppVeyor\BuildAgent\Modules\build-worker-api\build-worker-api.psm1:209 char:2
+     Push-AppveyorArtifactInternal -FullPath $fullPath -FileName $FileName -Deployme ...
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Push-AppveyorArtifactInternal], FileNotFoundException
    + FullyQualifiedErrorId : System.IO.FileNotFoundException,Appveyor.BuildAgent.Api.Utils.PushAppveyorArtifactInternalCmdlet
Member

ckerr commented Aug 9, 2018

appveyor: electron-ia32-pr failure is the app.enableMixedSandbox() flake

appveyor: electron-x64-pr failure is also unrelated to this PR:

Push-AppveyorArtifactInternal : File not found: C:\projects\electron-74j4h\out
At C:\Program Files\AppVeyor\BuildAgent\Modules\build-worker-api\build-worker-api.psm1:209 char:2
+     Push-AppveyorArtifactInternal -FullPath $fullPath -FileName $FileName -Deployme ...
+    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Push-AppveyorArtifactInternal], FileNotFoundException
    + FullyQualifiedErrorId : System.IO.FileNotFoundException,Appveyor.BuildAgent.Api.Utils.PushAppveyorArtifactInternalCmdlet
@ckerr

ckerr approved these changes Aug 9, 2018

@ckerr ckerr merged commit 3d89185 into electron:3-0-x Aug 9, 2018

10 of 12 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
appveyor: electron-x64-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment