New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use vs2017-15.4.5 for 3-0-x on AppVeyor #14022

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Aug 10, 2018

This PR updates Appveyor to use Visual Studio 2017 version 15.4.5 for 3-0-x. This includes a libcc update that is built with VS2017 15.4.5 see electron/libchromiumcontent#642

Fixes #13618 which is the issue of fetch failing on POST requests.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Use vs2017-15.4.5 for AppVeyor
Update to libcc with VS2017 15.4.5

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Aug 10, 2018

@ckerr

ckerr approved these changes Aug 10, 2018

@jkleinsc jkleinsc merged commit fb2afe8 into 3-0-x Aug 10, 2018

10 of 14 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
appveyor: electron-x64-branch AppVeyor build failed
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details

@jkleinsc jkleinsc deleted the 3-0-x-vs2017-15-4-5 branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment