Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Widevine CDM plugin has more requirements in >=v1.8.0 #14024

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@alexanderturinske
Copy link
Contributor

commented Aug 10, 2018

Describe changes in Widevine CDM plugin based on new widevine requirements

Relates to: #12427
Relates to: #10806

Checklist
  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Notes: Add docs on new widevine requirements.

@alexanderturinske alexanderturinske requested a review from as a code owner Aug 10, 2018

@welcome

This comment has been minimized.

Copy link

commented Aug 10, 2018

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@alexanderturinske

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2018

This was only a document change and all the errors in the console look unreleated

@zeke zeke changed the title docs: Widevine CDM pluggin has more requirements in >=v1.8.0 docs: Widevine CDM plugin has more requirements in >=v1.8.0 Aug 12, 2018

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

@alexanderturinske Sorry for taking a while to look at this, it looks like this change has picked up some conflicts, can you resolve those 👍

@alexanderturinske alexanderturinske force-pushed the alexanderturinske:patch-1 branch 2 times, most recently from b741d21 to ceb1f93 Oct 19, 2018

@alexanderturinske

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

Done

@alexanderturinske

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

@MarshallOfSound Plz review

@codebytere

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

@alexanderturinske could you please add release notes to your PR body and fix the following lint errors?

2018-10-19T01:20:02.6807378Z 
2018-10-19T01:20:04.3796501Z docs/tutorial/testing-widevine-cdm.md�
2018-10-19T01:20:04.3798198Z   11:1-17:4 Warning: Missing code-language flag  fenced-code-flag  remark-lint

@zcbenz zcbenz force-pushed the alexanderturinske:patch-1 branch from ceb1f93 to f33763a Nov 28, 2018

@zcbenz zcbenz merged commit f563fc9 into electron:master Nov 28, 2018

22 of 23 checks passed

ci/circleci: osx-testing-tests Your tests failed on CircleCI
Details
Absolute Zero
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Legacy commit status override — see details
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: mas-testing Your tests passed on CircleCI!
Details
ci/circleci: mas-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: osx-testing Your tests passed on CircleCI!
Details
electron-lint Build #20181128.5 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Nov 28, 2018

Release Notes Persisted

Add docs on new widevine requirements.

@welcome

This comment has been minimized.

Copy link

commented Nov 28, 2018

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.