New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override fs.realpathSync.native and fs.realpath.native #14031

Merged
merged 2 commits into from Aug 12, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Aug 11, 2018

Fixes electron/node#44.

Overrides fs.realpath.native and fs.realpathSync.native to account for asar paths.

/cc @ckerr @MarshallOfSound

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

@codebytere codebytere requested a review from electron/reviewers as a code owner Aug 11, 2018

@codebytere codebytere merged commit b785f45 into master Aug 12, 2018

14 of 19 checks passed

appveyor: electron-ia32-branch AppVeyor build failed
Details
ci/circleci: electron-gn-linux-ia32-debug-fyi Your tests failed on CircleCI
Details
ci/circleci: electron-gn-linux-ia32-release-fyi Your tests failed on CircleCI
Details
ci/circleci: electron-gn-linux-x64-release-fyi Your tests failed on CircleCI
Details
appveyor: electron-win-gn Waiting for AppVeyor build to complete
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-gn-linux-x64-debug-fyi Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details

@codebytere codebytere deleted the add-missing-fs branch Aug 12, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Aug 12, 2018

Member

/trop run backport-to 2-0-x

Member

ckerr commented Aug 12, 2018

/trop run backport-to 2-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 12, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

trop bot commented Aug 12, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "2-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 12, 2018

We have automatically backported this PR to "2-0-x", please check out #14039

trop bot commented Aug 12, 2018

We have automatically backported this PR to "2-0-x", please check out #14039

@trop trop bot added the merged/2-0-x label Aug 12, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Aug 13, 2018

Member

/trop run backport-to 3-0-x

Member

codebytere commented Aug 13, 2018

/trop run backport-to 3-0-x

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 13, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "3-0-x" here we go! :D

trop bot commented Aug 13, 2018

The backport process for this PR has been manually initiated, sending your 1's and 0's to "3-0-x" here we go! :D

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 13, 2018

We have automatically backported this PR to "3-0-x", please check out #14051

trop bot commented Aug 13, 2018

We have automatically backported this PR to "3-0-x", please check out #14051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment