New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify request context shutdown on IO before cleanup (backport: 3-0-x) #14092

Merged
merged 1 commit into from Aug 22, 2018

Conversation

3 participants
@trop

trop bot commented Aug 14, 2018

Backport of #14058

See that PR for details.

Fixes #13686

notes: fixes crash in net::ClientSocketHandle destructor

@trop trop bot requested a review from electron/reviewers as a code owner Aug 14, 2018

@trop trop bot referenced this pull request Aug 14, 2018

Merged

fix: notify request context shutdown on IO before cleanup #14058

5 of 5 tasks complete

@trop trop bot added the backport label Aug 14, 2018

@deepak1556 deepak1556 requested a review from ckerr Aug 17, 2018

@ckerr

ckerr approved these changes Aug 21, 2018

@codebytere codebytere merged commit 4c7af6a into electron:3-0-x Aug 22, 2018

12 of 13 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 22, 2018

Release Notes Persisted

fixes crash in net::ClientSocketHandle destructor

release-clerk bot commented Aug 22, 2018

Release Notes Persisted

fixes crash in net::ClientSocketHandle destructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment