Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roll node to fix fs.readSync bug #14118

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Aug 15, 2018

Description of Change

Fixes #13979.

This PR brings in electron/node@c86e3d3 in order to fix an issue with fs.readSync where large position values caused the function to work incorrectly.

Also pulls in build files necessary to build Node with GN.

/cc @ckerr @nornagon

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fixed a bug where fs.readSync worked incorrectly with large values of the position param

@codebytere codebytere requested a review from as a code owner Aug 15, 2018

@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Aug 15, 2018

Also pulls in build files necessary to build Node with GN.

Can it be avoided, we don't have working GN in 3.x line. There is no harm in pulling those changes, just considering an option.

@codebytere

This comment has been minimized.

Copy link
Member Author

codebytere commented Aug 15, 2018

@deepak1556 we're discussing this now, we'd like to avoid this as well.

@codebytere codebytere force-pushed the roll-node-3-0-x branch from 989f83a to 11aff63 Aug 15, 2018

@deepak1556 deepak1556 requested a review from nitsakh Aug 15, 2018

@ckerr

ckerr approved these changes Aug 15, 2018

Copy link
Member

ckerr left a comment

💚

@codebytere codebytere merged commit ef2ad40 into 3-0-x Aug 15, 2018

13 of 15 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 15, 2018

Release Notes Persisted

fixed a bug where fs.readSync worked incorrectly with large values of the position param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.