New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not bubble up resize event from webview (2-0-x) #14272

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
1 participant
@zcbenz
Contributor

zcbenz commented Aug 23, 2018

Backport #14271 to 2-0-x.

notes: fix the problem that resizing webview triggers resize event on window.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Aug 23, 2018

@zcbenz zcbenz merged commit 760c232 into 2-0-x Aug 23, 2018

15 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 23, 2018

Release Notes Persisted

fix the problem that resizing webview triggers resize event on window.

release-clerk bot commented Aug 23, 2018

Release Notes Persisted

fix the problem that resizing webview triggers resize event on window.

@zcbenz zcbenz deleted the webview-resize-bubbles-2-0-x branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment