Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt into location services once device service has been started (backport: 3-0-x) #14289

Merged
merged 2 commits into from Aug 24, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Aug 24, 2018

Description of Change

Backport of #14253.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: Fix issue with geolocation.getCurrentPosition callback being called

@codebytere codebytere requested a review from deepak1556 Aug 24, 2018

@codebytere codebytere requested a review from as a code owner Aug 24, 2018

BUILD.gn Outdated
@@ -312,6 +318,92 @@ static_library("electron_lib") {
sources = filenames_gypi.lib_sources
set_sources_assignment_filter(sources_assignment_filter)

<<<<<<< HEAD
=======

This comment has been minimized.

@deepak1556

deepak1556 Aug 24, 2018

Member

Conflict needs to be fixed.

@deepak1556 deepak1556 changed the title fix: opt into location services once device service has been started fix: opt into location services once device service has been started (backport: 3-0-x) Aug 24, 2018

@deepak1556
Copy link
Member

deepak1556 left a comment

Thanks!

deepak1556 and others added some commits Aug 23, 2018

fix: opt into location services once device service has been started (#…
…14253)

* fix: opt into location services once device service has been started

* refactor: provide fake location provider to mock geolocation reponses

* chore: add spec for navigator.geolocation api using fake location provider

@codebytere codebytere force-pushed the geolocation-backport branch from de4fa95 to 6240c80 Aug 24, 2018

@codebytere codebytere merged commit 4721dc0 into 3-0-x Aug 24, 2018

15 of 16 checks passed

appveyor: electron-x64-branch AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 24, 2018

Release Notes Persisted

Fix issue with geolocation.getCurrentPosition callback being called

@deepak1556 deepak1556 deleted the geolocation-backport branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.