New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: roll node (2-0-x) #14298

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
4 participants
@codebytere
Member

codebytere commented Aug 24, 2018

Description of Change

Pulls in electron/node#53.

/cc @MarshallOfSound @deepak1556 @ckerr

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Noteshttps://github.com/electron/clerk/blob/master/README.md for details. -->

Notes: no-notes

@codebytere codebytere requested a review from electron/reviewers as a code owner Aug 24, 2018

@MarshallOfSound MarshallOfSound changed the title from deps: roll node (2-0-x) to chore: roll node (2-0-x) Aug 24, 2018

@ckerr

ckerr approved these changes Aug 24, 2018

@ckerr ckerr merged commit 3bc9ae7 into 2-0-x Aug 24, 2018

16 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 24, 2018

No Release Notes

release-clerk bot commented Aug 24, 2018

No Release Notes

@ckerr ckerr deleted the roll-node-2-0-x branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment