New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't expose view APIs when not enabled (backport: 3-0-x) #14321

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Aug 26, 2018

Backport of #14312

See that PR for details.

Fixes #13930

Notes: Removes access to experimental view APIs unless enabled in features.

@trop trop bot requested a review from electron/reviewers as a code owner Aug 26, 2018

@trop trop bot referenced this pull request Aug 26, 2018

Merged

fix: don't expose view APIs when not enabled #14312

3 of 3 tasks complete

@trop trop bot added the backport label Aug 26, 2018

@zcbenz zcbenz merged commit ff539c1 into electron:3-0-x Aug 27, 2018

12 of 13 checks passed

appveyor: electron-x64-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 27, 2018

Release Notes Persisted

Removes access to experimental view APIs unless enabled in features.

release-clerk bot commented Aug 27, 2018

Release Notes Persisted

Removes access to experimental view APIs unless enabled in features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment