Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash on tray.setContextMenu(null) (backport: 2-0-x) #14330

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Aug 27, 2018

Backport of #14322

See that PR for details.

Fixes #14188

Notes: no-notes

@trop trop bot requested review from as code owners Aug 27, 2018

@trop trop bot referenced this pull request Aug 27, 2018

Merged

fix: don't crash on tray.setContextMenu(null) #14322

5 of 5 tasks complete

@trop trop bot added the backport label Aug 27, 2018

@ckerr ckerr merged commit 7ed6e2b into electron:2-0-x Aug 27, 2018

13 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 27, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.