New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) #14334

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@ckerr
Member

ckerr commented Aug 27, 2018

Backport of #14297 into 2-0-x

CC @codebytere

Notes: Stop handling node arguments after a "--" on the CLI

@ckerr ckerr added the target/1-8-x label Aug 27, 2018

@ckerr ckerr requested a review from electron/reviewers as a code owner Aug 27, 2018

@ckerr ckerr changed the title from fix: dont parse arguments after a -- in the inspector (#14297) to fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) Aug 27, 2018

@codebytere

LGTM

@ckerr ckerr changed the title from fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) to [WIP] fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) Aug 27, 2018

@ckerr ckerr changed the title from [WIP] fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) to fix: dont parse arguments after a -- in the inspector (#14297) (2-0-x) Aug 27, 2018

@ckerr ckerr merged commit b4c5a30 into 2-0-x Aug 27, 2018

13 of 16 checks passed

appveyor: electron-x64-branch AppVeyor build failed
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 27, 2018

Release Notes Persisted

Stop handling node arguments after a "--" on the CLI

release-clerk bot commented Aug 27, 2018

Release Notes Persisted

Stop handling node arguments after a "--" on the CLI

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 27, 2018

An error occurred while attempting to backport this PR to "1-7-x",
you will need to perform this backport manually

trop bot commented Aug 27, 2018

An error occurred while attempting to backport this PR to "1-7-x",
you will need to perform this backport manually

@trop

This comment has been minimized.

Show comment
Hide comment
@trop

trop bot Aug 27, 2018

We have automatically backported this PR to "1-8-x", please check out #14338

trop bot commented Aug 27, 2018

We have automatically backported this PR to "1-8-x", please check out #14338

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Aug 27, 2018

@alexeykuzmin alexeykuzmin deleted the dd-parsing_2-0-x branch Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment