Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't expose desktopCapturer in sandboxed renderers when the feature is disabled (backport: 3-0-x) #14345

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@miniak
Copy link
Contributor

miniak commented Aug 28, 2018

Description of Change

Backport #14310

Checklist
Release Notes

Notes: Don't expose desktopCapturer in sandboxed renderers when the feature is disabled.

@miniak miniak requested review from as code owners Aug 28, 2018

@miniak miniak changed the base branch from master to 3-0-x Aug 28, 2018

@miniak

This comment has been minimized.

Copy link
Contributor Author

miniak commented Aug 28, 2018

cc @ckerr

@miniak miniak force-pushed the miniak/desktop-capturer-3.0 branch from 093d443 to ad55ef8 Aug 28, 2018

@ckerr

ckerr approved these changes Aug 29, 2018

@ckerr ckerr merged commit 3301e05 into 3-0-x Aug 29, 2018

16 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 29, 2018

Release Notes Persisted

Don't expose desktopCapturer in sandboxed renderers when the feature is disabled.

@ckerr ckerr deleted the miniak/desktop-capturer-3.0 branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.