New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when tray is destroyed (backport: 3-0-x) #14357

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Aug 28, 2018

Backport of #14347

See that PR for details.

Notes: no-notes

fix: crash when tray is destroyed
Release the view of status item before destroying it,
gives chance to perform cleanup on the view.

@trop trop bot requested a review from electron/reviewers as a code owner Aug 28, 2018

@trop trop bot referenced this pull request Aug 28, 2018

Merged

fix: crash when tray is destroyed #14347

5 of 5 tasks complete

@trop trop bot added the backport label Aug 28, 2018

@ckerr

ckerr approved these changes Aug 28, 2018

@ckerr ckerr merged commit 873f39b into electron:3-0-x Aug 28, 2018

12 of 13 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 28, 2018

No Release Notes

release-clerk bot commented Aug 28, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment