Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create persistent channel ID store when cookie store is persistent (backport: 3-0-x) #14358

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Aug 28, 2018

Backport of #14107

See that PR for details.

Fixes #13906

Notes: no-notes

@trop trop bot requested a review from as a code owner Aug 28, 2018

@trop trop bot added the backport label Aug 28, 2018

@ckerr

ckerr approved these changes Aug 28, 2018

@ckerr ckerr merged commit 11864e9 into electron:3-0-x Aug 28, 2018

8 of 12 checks passed

ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-mas-x64 Your tests are queued behind your running builds
Details
ci/circleci: electron-osx-x64 Your tests are queued behind your running builds
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 28, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.