Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use OS process handle to clear object registry (backport: 3-0-x) #14364

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Aug 28, 2018

Backport of #14324

See that PR for details.

Fixes #14054

Notes: no-notes

fix: use OS process handle to clear object registry
RenderProcessHost switch can happen between ipc calls when
speculative process are invvolved, which will lead to deletion
of entries on current context. Use OS process handles to
uniquely associate a destruction handler for a render process.

@trop trop bot requested a review from as a code owner Aug 28, 2018

@trop trop bot referenced this pull request Aug 28, 2018

Merged

fix: use OS process handle to clear object registry #14324

5 of 5 tasks complete

@trop trop bot added the backport label Aug 28, 2018

@codebytere codebytere merged commit ccf8a79 into electron:3-0-x Aug 29, 2018

11 of 13 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
ci/circleci: electron-linux-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 29, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.