docs: add missing documentation for <webview> methods #14413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/webview-docs
branch
from
1cfa95f
to
8ef6adf
Compare
docs/api/webview-tag.md
Outdated
| @@ -267,6 +267,12 @@ webview.addEventListener('dom-ready', () => { | |||
| Loads the `url` in the webview, the `url` must contain the protocol prefix, | |||
| e.g. the `http://` or `file://`. | |||
|
|
|||
| #### `contents.downloadURL(url)` | |||
There was a problem hiding this comment.
@MarshallOfSound fixed
miniak
force-pushed
the
miniak/webview-docs
branch
from
8ef6adf
to
766b033
Compare
MarshallOfSound
approved these changes
Sep 3, 2018
|
Release Notes Persisted
|
|
An error occurred while attempting to backport this PR to "2-0-x", |
|
An error occurred while attempting to backport this PR to "3-0-x", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There are several public methods exposed by
<webview>(web-view.js) missing in the documentation and thereforeelectron.d.tsdownloadURL(url: string): void;isLoadingMainFrame(): boolean;isCurrentlyAudible(): boolean;getZoomFactor(callback: (zoomFactor: number) => void): void;getZoomLevel(callback: (zoomLevel: number) => void): void;setVisualZoomLevelLimits(minimumLevel: number, maximumLevel: number): void;setLayoutZoomLevelLimits(minimumLevel: number, maximumLevel: number): void;Checklist
Release Notes
Notes: Added missing documentation for
<webview>methods.