Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: roll node deps to deprecate fs functions #14467

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Sep 5, 2018

Description of Change

Roll node to deprecate statSyncNoException and lstatSyncNoException.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: Deprecate statSyncNoException and lstatSyncNoException.

@codebytere codebytere requested a review from as a code owner Sep 5, 2018

@codebytere codebytere changed the title deps: roll node to deprecate fs functions chore: roll node deps to deprecate fs functions Sep 5, 2018

@codebytere codebytere merged commit 85c8ada into 3-0-x Sep 5, 2018

16 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 5, 2018

Release Notes Persisted

Deprecate statSyncNoException and lstatSyncNoException.

@codebytere codebytere deleted the roll-node-3-0-x branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.