New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify VS 2017 15.4.5 for 3-0-x #14476

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Sep 6, 2018

Description of Change

Due to electron/libchromiumcontent#642, we moved our 3-0-x libchromiumcontent builds to use Visual Studio 15.4.5. This means that if you are building Electron on 3-0-x, you will get an error if you try to use a newer version of Visual Studio. This documentation update includes links to download the specific version of Visual Studio 2017 required.

Resolves #12898

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Updated Visual Studio 2017 requirement for 3-0-x

@jkleinsc jkleinsc requested a review from electron/docs as a code owner Sep 6, 2018

@MarshallOfSound MarshallOfSound merged commit 08270e6 into 3-0-x Sep 6, 2018

14 of 16 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 6, 2018

Release Notes Persisted

Updated Visual Studio 2017 requirement for 3-0-x

release-clerk bot commented Sep 6, 2018

Release Notes Persisted

Updated Visual Studio 2017 requirement for 3-0-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment