Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS window title and accessibility focus (backport: 3-0-x) #14486

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Sep 6, 2018

Backport of #14472

See that PR for details.

Notes: no-notes

Macos Window Title And Accessibility Focus Fix - Override accessibili…
…ty method in atom_ns_window - Add title attribute in accessibilityAttributeValue

@trop trop bot requested a review from as a code owner Sep 6, 2018

@trop trop bot referenced this pull request Sep 6, 2018

Merged

fix: macOS window title and accessibility focus #14472

3 of 3 tasks complete

@trop trop bot added the backport label Sep 6, 2018

@codebytere codebytere merged commit a370b69 into electron:3-0-x Sep 7, 2018

11 of 13 checks passed

appveyor: electron-ia32-pr AppVeyor build failed
Details
appveyor: electron-x64-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 7, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.