New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually manage WebContents of webview when it is detached (3-0-x) #14488

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@zcbenz
Contributor

zcbenz commented Sep 7, 2018

This PR relies on electron/libchromiumcontent#677.

Backports #14487 to 3-0-x.

Release Notes

Notes: Fix webview freezing on navigation.

@zcbenz zcbenz requested a review from electron/reviewers as a code owner Sep 7, 2018

@jkleinsc jkleinsc merged commit 03dac07 into 3-0-x Sep 7, 2018

16 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 7, 2018

Release Notes Persisted

Fix webview freezing on navigation.

release-clerk bot commented Sep 7, 2018

Release Notes Persisted

Fix webview freezing on navigation.

@jkleinsc jkleinsc deleted the manage-webview-webcontents-3-0-x branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment