New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify focus change right away rather not on next tick (3-0-x) #14494

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
4 participants
@jkleinsc
Contributor

jkleinsc commented Sep 7, 2018

Description of Change

Backport #14453 to 3-0-x

Checklist
Release Notes

Notes: Fixed windows multiple windows focus bug.

fix: notify focus change right away rather not on next tick (#14453)
* fix: Notify focus change right away, not on next tick

* fix: emit the JS blur/focus events on next tick to avoid race condition

* address feedback from review

* fix: bind deferred Emit() calls to a WeakPtr

This is so that the deferred Emit() calls will be canceled
if the TopLevelWindow is destroyed.

* chore: remove wip/test code cruft

* fix: make linter happy

* Enable disabled tests

* refactor: cleaner impl of EmitEventSoon()

* Revert "Merge branch 'fix-win-focus' of github.com:electron/electron into fix-win-focus"

This reverts commit 9057680, reversing
changes made to 9c13e47.

* Restore 704722c, which was removed in error.

We apologise again for the fault in the subtitles. Those responsible for sacking the people who have just been sacked have been sacked.

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Sep 7, 2018

@ckerr

ckerr approved these changes Sep 7, 2018

@jkleinsc jkleinsc merged commit 27a33cc into 3-0-x Sep 7, 2018

13 of 16 checks passed

WIP work in progress
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-branch AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found

@jkleinsc jkleinsc deleted the fix-focus-3-0-x branch Sep 7, 2018

@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 7, 2018

Release Notes Persisted

Fixed windows multiple windows focus bug.

release-clerk bot commented Sep 7, 2018

Release Notes Persisted

Fixed windows multiple windows focus bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment