New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable power monitor test (3-0-x) #14496

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Sep 7, 2018

Description of Change

Backport of #14458.

/cc @ckerr

Release Notes

Notes: no-notes

@codebytere codebytere requested a review from ckerr Sep 7, 2018

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 7, 2018

@codebytere codebytere changed the title from fix: re-enable power monitor test to fix: re-enable power monitor test (3-0-x) Sep 7, 2018

@ckerr

ckerr approved these changes Sep 7, 2018

@codebytere codebytere merged commit d36b14a into 3-0-x Sep 7, 2018

14 of 16 checks passed

appveyor: electron-x64-branch AppVeyor build failed
Details
ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 7, 2018

No Release Notes

release-clerk bot commented Sep 7, 2018

No Release Notes

@codebytere codebytere deleted the powermonitor-bp branch Sep 8, 2018

alexeykuzmin added a commit that referenced this pull request Sep 9, 2018

alexeykuzmin added a commit that referenced this pull request Sep 9, 2018

MarshallOfSound added a commit that referenced this pull request Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment