New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use render client id to track deleted render process hosts (backport: 3-0-x) #14557

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@deepak1556
Member

deepak1556 commented Sep 11, 2018

Description of Change

Backports #14520
Fixes #14054

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: fix missing remote objects #14054

@deepak1556 deepak1556 requested a review from electron/reviewers as a code owner Sep 11, 2018

@deepak1556 deepak1556 requested a review from ckerr Sep 11, 2018

@ckerr

ckerr approved these changes Sep 11, 2018

@deepak1556 deepak1556 changed the title from fix: use render client id to track deleted render process hosts (backport: 3-0-x) to [WIP] fix: use render client id to track deleted render process hosts (backport: 3-0-x) Sep 11, 2018

@deepak1556 deepak1556 changed the title from [WIP] fix: use render client id to track deleted render process hosts (backport: 3-0-x) to fix: use render client id to track deleted render process hosts (backport: 3-0-x) Sep 12, 2018

@codebytere codebytere merged commit 8d27657 into 3-0-x Sep 12, 2018

17 of 19 checks passed

appveyor: electron-x64-branch AppVeyor build failed
Details
appveyor: gn-win-x64-testing AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-branch AppVeyor build succeeded
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
appveyor: gn-win-ia32-debug AppVeyor build succeeded
Details
appveyor: gn-win-ia32-testing AppVeyor build succeeded
Details
appveyor: gn-win-x64-debug AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 12, 2018

Release Notes Persisted

fix missing remote objects #14054

release-clerk bot commented Sep 12, 2018

Release Notes Persisted

fix missing remote objects #14054

@deepak1556 deepak1556 deleted the object_registry_patch_3-0-x branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment