New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run gn debug build on older branches #14584

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@jkleinsc
Contributor

jkleinsc commented Sep 12, 2018

Older branches that build using gyp do not run both a debug and testing build, so this PR will disable the appveyor: win-ia32-debug and appveyor: win-x64-debug jobs for 3-0-x and older branches. For 3-0-x and older branches the appveyor: win-ia32-testing-pr, appveyor: win-ia32-testing, appveyor: win-x64-testing-pr and appveyor: win-x64-testing builds will be used to for testing purposes.

Description of Change
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

ci: don't run gn debug build on older branches
Older branches that build using gyp do not run both a debug and testing build.

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Sep 12, 2018

Show resolved Hide resolved appveyor.yml
@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Sep 12, 2018

Member

@jkleinsc i don't think this is a clean backport on any branches :(

Member

codebytere commented Sep 12, 2018

@jkleinsc i don't think this is a clean backport on any branches :(

@codebytere codebytere merged commit f924a16 into 3-0-x Sep 12, 2018

17 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 12, 2018

No Release Notes

release-clerk bot commented Sep 12, 2018

No Release Notes

@codebytere codebytere deleted the ignore-gn-debug-builds branch Sep 12, 2018

jkleinsc added a commit that referenced this pull request Sep 12, 2018

ci: don't run gn debug build on older branches (#14584)
* ci: don't run gn debug build on older branches

Older branches that build using gyp do not run both a debug and testing build.

* Actually skip the build if debug

(cherry picked from commit f924a16)

@jkleinsc jkleinsc referenced this pull request Sep 12, 2018

Merged

ci: don't run gn debug build on older branches (2-0-x) #14593

3 of 3 tasks complete

jkleinsc added a commit that referenced this pull request Sep 12, 2018

ci: don't run gn debug build on older branches (#14584)
* ci: don't run gn debug build on older branches

Older branches that build using gyp do not run both a debug and testing build.

* Actually skip the build if debug

(cherry picked from commit f924a16)
(cherry picked from commit 5f3bedd)

@jkleinsc jkleinsc referenced this pull request Sep 12, 2018

Merged

ci: don't run gn debug build on older branches (1-8-x) #14594

3 of 3 tasks complete

jkleinsc added a commit that referenced this pull request Sep 12, 2018

ci: don't run gn debug build on older branches (#14584)
* ci: don't run gn debug build on older branches

Older branches that build using gyp do not run both a debug and testing build.

* Actually skip the build if debug

(cherry picked from commit f924a16)
(cherry picked from commit 5f3bedd)

@jkleinsc jkleinsc referenced this pull request Sep 12, 2018

Merged

ci: don't run gn debug build on older branches (1-7-x) #14595

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment