New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalidate weak ptrs before window Javascript object is destroyed (backport: 3-0-x) #14591

Merged
merged 3 commits into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@trop

trop bot commented Sep 12, 2018

Backport of #14532

See that PR for details.

Fixes #14513

Notes: no-notes

deepak1556 and others added some commits Sep 10, 2018

chore: add regression test for #14513
This test is similar to the original gist at https://gist.github.com/bpasero/a02a645e11f4946dcca1331d0299149d -- the key is to open multiple windows and add an `app.on('browser-window-focus') listener that accesses window.id.
fix: last commit didn't test the right thing.
The test needs to run in the main process to reproduce the
conditions reported in #14513

@trop trop bot requested a review from electron/reviewers as a code owner Sep 12, 2018

@trop trop bot added the backport label Sep 12, 2018

@ckerr

ckerr approved these changes Sep 12, 2018

@ckerr ckerr merged commit 02b1069 into electron:3-0-x Sep 12, 2018

11 of 13 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
appveyor: win-x64-testing-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 12, 2018

No Release Notes

release-clerk bot commented Sep 12, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment