New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Windows Background color issue (backport: 3-0-x) #14592

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Sep 12, 2018

Backport of #14561

See that PR for details.

Notes: no-notes

fix: Windows Background color issue
Call InvalidateRect for windows after setting the bg color

@trop trop bot requested a review from electron/reviewers as a code owner Sep 12, 2018

@trop trop bot referenced this pull request Sep 12, 2018

Merged

fix: Windows Background color issue #14561

3 of 3 tasks complete

@trop trop bot added the backport label Sep 12, 2018

@ckerr

This comment has been minimized.

Show comment
Hide comment
@ckerr

ckerr Sep 12, 2018

Member

Ahhh we should've had this in b12

Member

ckerr commented Sep 12, 2018

Ahhh we should've had this in b12

@ckerr ckerr merged commit 7e5815c into electron:3-0-x Sep 12, 2018

11 of 13 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 12, 2018

No Release Notes

release-clerk bot commented Sep 12, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment