New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run gn debug build on older branches (2-0-x) #14593

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@jkleinsc
Contributor

jkleinsc commented Sep 12, 2018

Backports #14584 to 2-0-x.

  • ci: don't run gn debug build on older branches

Older branches that build using gyp do not run both a debug and testing build.

(cherry picked from commit f924a16)

Description of Change
Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

ci: don't run gn debug build on older branches (#14584)
* ci: don't run gn debug build on older branches

Older branches that build using gyp do not run both a debug and testing build.

* Actually skip the build if debug

(cherry picked from commit f924a16)

@jkleinsc jkleinsc requested a review from electron/reviewers as a code owner Sep 12, 2018

@jkleinsc jkleinsc changed the title from ci: don't run gn debug build on older branches to ci: don't run gn debug build on older branches (2-0-x) Sep 12, 2018

@jkleinsc jkleinsc merged commit 67a690e into 2-0-x Sep 13, 2018

17 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 13, 2018

No Release Notes

release-clerk bot commented Sep 13, 2018

No Release Notes

@jkleinsc jkleinsc deleted the ignore-gn-debug-builds-2-0-x branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment