feat: automatically round numbers that are converted to points #14604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
auto-round-points
branch
from
da2c4fe
to
84b71a3
Compare
ckerr
approved these changes
Sep 13, 2018
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14490
Description of Change
Points that are taken in as input to Electron API's are now auto rounded if floats are provided as input. E.g.
{ x: 5.5, y: 6 }becomes{ x: 6, y: 6 }. This is the current expected user workaround and will have no impact on currently working code however I consider thissemver/minor.Release Notes
Notes: Point based API's now automatically round incoming
xandyvalues