New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecation handling apis #14615

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@codebytere
Member

codebytere commented Sep 13, 2018

Description of Change

Combination backport of #14495 and #14579.

Fixes issue whereby we were printing:

(electron) The 'privateBytes' property of function getAppMetrics() { [native code] } has been deprecated and marked for removal.

/cc @ckerr

Checklist
Release Notes

Notes: no-notes

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 13, 2018

@ckerr

Commenting to say thanks for keeping me in the loop 👍

Not reviewing because so much of this is a backport of the deprecate refactor I wrote

@codebytere codebytere merged commit 89148bc into 3-0-x Sep 14, 2018

16 of 17 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 14, 2018

No Release Notes

release-clerk bot commented Sep 14, 2018

No Release Notes

@MarshallOfSound MarshallOfSound deleted the bp-deprecation branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment