New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quit properly in simpleFullScreen mode (backport: 3-0-x) #14646

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
1 participant
@trop

trop bot commented Sep 17, 2018

Backport of #14620

See that PR for details.

Fixes #13135

Notes: no-notes

@trop trop bot requested a review from electron/reviewers as a code owner Sep 17, 2018

@trop trop bot referenced this pull request Sep 17, 2018

Merged

fix: quit properly in simpleFullScreen mode #14620

3 of 3 tasks complete

@trop trop bot added the backport label Sep 17, 2018

@codebytere codebytere merged commit 96c47ef into electron:3-0-x Sep 17, 2018

11 of 13 checks passed

ci/circleci: electron-mas-x64 Your tests failed on CircleCI
Details
ci/circleci: electron-osx-x64 Your tests failed on CircleCI
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 17, 2018

No Release Notes

release-clerk bot commented Sep 17, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment