New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dont pass --stable through to bump-version.py (backport: 2-0-x) #14667

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
1 participant
@trop

trop bot commented Sep 18, 2018

Backport of #14661

See that PR for details.

Notes: no-notes

chore: dont pass --stable through to bump-version.py
I want to clean up this "stable" and "beta" code smell eventually but
for now this will unblock the 2.0.x releases.

@trop trop bot requested a review from electron/reviewers as a code owner Sep 18, 2018

@trop trop bot added the backport label Sep 18, 2018

@MarshallOfSound MarshallOfSound merged commit 79af1ea into electron:2-0-x Sep 18, 2018

5 of 13 checks passed

appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
ci/circleci: electron-linux-arm-test CircleCI is running your tests
Details
ci/circleci: electron-linux-arm64-test CircleCI is running your tests
Details
ci/circleci: electron-linux-ia32 CircleCI is running your tests
Details
ci/circleci: electron-linux-x64 CircleCI is running your tests
Details
ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 18, 2018

No Release Notes

release-clerk bot commented Sep 18, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment