New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quit properly in simpleFullScreen mode (2-0-x) #14671

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Sep 18, 2018

Description of Change

Backport of #14620.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fixes issue with app.quit() in simpleFullScreen mode

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 18, 2018

@codebytere codebytere changed the title from fix: quit properly in simpleFullScreen mode to fix: quit properly in simpleFullScreen mode (2-0-x) Sep 19, 2018

@codebytere

This comment has been minimized.

Show comment
Hide comment
@codebytere

codebytere Sep 19, 2018

Member

👇 the vsts failures are from runs that shouldn't have occurred

Member

codebytere commented Sep 19, 2018

👇 the vsts failures are from runs that shouldn't have occurred

@codebytere codebytere merged commit d709421 into 2-0-x Sep 19, 2018

17 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 19, 2018

Release Notes Persisted

fixes issue with app.quit() in simpleFullScreen mode

release-clerk bot commented Sep 19, 2018

Release Notes Persisted

fixes issue with app.quit() in simpleFullScreen mode

@codebytere codebytere deleted the fix-simple-fullscreen-2-0-x branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment