New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GN linting #14678

Merged
merged 7 commits into from Oct 3, 2018

Conversation

6 participants
@nornagon
Contributor

nornagon commented Sep 18, 2018

Description of Change

Runs gn format over *.gn and *.gni files. Use --fix to fix the errors automatically.

Checklist
  • PR description included and stakeholders cc'd
  • PR title follows semantic commit guidelines
Release Notes

Notes: no-notes

@nornagon nornagon requested a review from ckerr Sep 18, 2018

@nornagon nornagon requested a review from electron/reviewers as a code owner Sep 18, 2018

@nornagon

This comment has been minimized.

Contributor

nornagon commented Sep 18, 2018

d'oh, the lint CI job doesn't run from a gclient sync'd directory, so it doesn't have a copy of gn. I'll see if I can fix that without having to get a full gclient sync. WIP.

@nornagon nornagon changed the title from chore: add GN linting to [wip] chore: add GN linting Sep 18, 2018

@alexeykuzmin

This comment has been minimized.

Contributor

alexeykuzmin commented Sep 19, 2018

@nornagon nornagon added this to In Progress in GN followup Sep 24, 2018

@nornagon

This comment has been minimized.

Contributor

nornagon commented Sep 25, 2018

This is working now! The lint errors are legit errors. The bash stuff is a bit crazy though.

@nornagon nornagon changed the title from [wip] chore: add GN linting to chore: add GN linting Sep 25, 2018

@@ -13,7 +13,17 @@ steps:
name: Setup_depot_tools
- bash: |
chromium_revision="$(grep -A1 chromium_version DEPS | tr -d '\n' | cut -d\' -f4)"
buildtools_revision="$(curl -sL "https://chromium.googlesource.com/chromium/src/+/${chromium_revision}/DEPS?format=TEXT" | base64 -d | grep buildtools_revision -A1 | tr -d '\n' | cut -d\' -f4)"

This comment has been minimized.

@MarshallOfSound

MarshallOfSound Oct 2, 2018

Member

This is wild and I love it 😆

This comment has been minimized.

@alexeykuzmin

alexeykuzmin Oct 3, 2018

Contributor

I will be broken in less than a month =)

@alexeykuzmin

@nornagon I rebased it on the latest master to resolve conflicts.
Should work for now.

But the whole thing will break soon, once we upgrade to a Chromium revision which uses gn binary from //third_party/gn.

@ckerr

ckerr approved these changes Oct 3, 2018

@ckerr ckerr merged commit 14fc6f3 into master Oct 3, 2018

30 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: linux-arm-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-native-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-arm-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-native-mksnapshot Your tests passed on CircleCI!
Details
ci/circleci: linux-arm64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-checkout Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-ia32-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-debug Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-ffmpeg Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-tests Your tests passed on CircleCI!
Details
ci/circleci: linux-x64-testing-verify-ffmpeg Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

release-clerk bot commented Oct 3, 2018

No Release Notes

@ckerr ckerr deleted the lint-gn branch Oct 3, 2018

@nornagon nornagon moved this from In Progress to Done in GN followup Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment