New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix await in cleanup script (backport: 2-0-x) #14694

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
1 participant
@trop

trop bot commented Sep 19, 2018

Backport of #14670

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from electron/reviewers as a code owner Sep 19, 2018

@trop trop bot referenced this pull request Sep 19, 2018

Merged

chore: fix await in cleanup script #14670

3 of 3 tasks complete

@trop trop bot added the backport label Sep 19, 2018

@codebytere codebytere merged commit 0e5f734 into electron:2-0-x Sep 19, 2018

13 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 19, 2018

No Release Notes

release-clerk bot commented Sep 19, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment