New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify BrowserWindow features passable to window.open (backport: 2-0-x) #14701

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Sep 19, 2018

Backport of #14526

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from electron/docs as a code owner Sep 19, 2018

@trop trop bot referenced this pull request Sep 19, 2018

Merged

docs: specify BrowserWindow features passable to window.open #14526

3 of 3 tasks complete

@trop trop bot added the backport label Sep 19, 2018

@MarshallOfSound MarshallOfSound merged commit 36da7dc into electron:2-0-x Sep 20, 2018

11 of 12 checks passed

ci/circleci: electron-linux-ia32 Your tests failed on CircleCI
Details
WIP ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 20, 2018

No Release Notes

release-clerk bot commented Sep 20, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment