New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually return appmetrics in 3-0-x #14750

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Member

MarshallOfSound commented Sep 21, 2018

Fixes #14710

Notes: fix app.getAppMetrics returning undefined in 3.0.0

@MarshallOfSound MarshallOfSound requested a review from electron/reviewers as a code owner Sep 21, 2018

@ckerr

ckerr approved these changes Sep 21, 2018

💯

How on earth did this pass CI before

@ckerr ckerr added this to PR in Flight in 3.0.x Sep 21, 2018

@ckerr ckerr removed this from PR in Flight in 3.0.x Sep 21, 2018

@ckerr ckerr merged commit db03841 into 3-0-x Sep 21, 2018

16 checks passed

WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 21, 2018

Release Notes Persisted

fix app.getAppMetrics returning undefined

release-clerk bot commented Sep 21, 2018

Release Notes Persisted

fix app.getAppMetrics returning undefined

@ckerr ckerr deleted the MarshallOfSound-patch-1 branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment