New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent titleBarStyle on transparent fullscreen (2-0-x) #14792

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@codebytere
Member

codebytere commented Sep 25, 2018

Description of Change

Backport of #14765.
See that commit for details.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines
Release Notes

Notes: fix inconsistent titleBarStyle on transparent fullscreen

@codebytere codebytere requested a review from electron/reviewers as a code owner Sep 25, 2018

@codebytere codebytere changed the title from fix: inconsistent titleBarStyle on transparent fullscreen to fix: inconsistent titleBarStyle on transparent fullscreen (2-0-x) Sep 25, 2018

@jkleinsc

LGTM

@jkleinsc jkleinsc merged commit 503b488 into 2-0-x Sep 25, 2018

17 checks passed

Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-mas-x64 Your tests passed on CircleCI!
Details
ci/circleci: electron-osx-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Sep 25, 2018

Release Notes Persisted

fix inconsistent titleBarStyle on transparent fullscreen

release-clerk bot commented Sep 25, 2018

Release Notes Persisted

fix inconsistent titleBarStyle on transparent fullscreen

@jkleinsc jkleinsc deleted the fix-hiddeninset-titlebar-2-0-x branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment